Integration with Doc Prop #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
gris
suggested changes
Jul 16, 2020
|
@juliarocha can you comment here some workspaces with your contributions. Examples with and without docprop, please? |
victorhmp
requested changes
Jul 16, 2020
|
Looking good. I would only fix the minor lint issues and put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you change? *
Added integration with Doc Prop via markdown placeholder.
Why? *
Keeping the Store Components documentation up to date with the code and independent from manual documentation.
How to test it? *
Doc Prop working on some components:
https://juzon--appliancetheme.myvtex.com/docs/app/[email protected]/
https://juzon--appliancetheme.myvtex.com/docs/app/[email protected]/ (beta version - migration in PR)
Components without Doc Prop:
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.flex-layout
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.rich-text (current version)
Types of changes *